Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings: override is needed #210

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Fix warnings: override is needed #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion denops/@ddc-filters/skkeleton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { type Item } from "../skkeleton/deps/ddc/types.ts";
type Params = Record<string, never>;

export class Filter extends BaseFilter<Params> {
async filter(
override async filter(
args: FilterArguments<Params>,
): Promise<Item<CompletionMetadata>[]> {
await args.denops.cmd("echomsg msg", {
Expand Down
10 changes: 5 additions & 5 deletions denops/@ddc-sources/skkeleton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type CompletionMetadata = {
type Params = Record<string, never>;

export class Source extends BaseSource<Params> {
async getCompletePosition(
override async getCompletePosition(
args: GetCompletePositionArguments<Record<string, never>>,
): Promise<number> {
const inputLength = args.context.input.length;
Expand All @@ -27,7 +27,7 @@ export class Source extends BaseSource<Params> {
return inputLength - preEditLength;
}

async gather(
override async gather(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For abstract method override keyword is not necessary. Please see microsoft/TypeScript#47250 for the reason.

Suggested change
override async gather(
async gather(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the issue.
It is not necessary.
But to add override is requested in the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, indeed.

args: GatherArguments<Params>,
): Promise<DdcGatherItems> {
const candidates = (await args.denops.dispatch(
Expand Down Expand Up @@ -70,11 +70,11 @@ export class Source extends BaseSource<Params> {
};
}

params() {
override params() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
override params() {
params() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with microsoft/TypeScript#47250.

return {};
}

getPreviewer(
override getPreviewer(
args: GetPreviewerArguments<Params, unknown>,
): Promise<Previewer> {
if (!args.item.info || args.item.info.length === 0) {
Expand All @@ -89,7 +89,7 @@ export class Source extends BaseSource<Params> {
});
}

async onCompleteDone(
override async onCompleteDone(
args: OnCompleteDoneArguments<Params, CompletionMetadata>,
) {
await args.denops.dispatch(
Expand Down
Loading