This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Fix issue where dependencies were not being tracked when checking produced files #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a setup like
where
a
just saves out an rds asdata.rds
then b has ymlAnd the script
When running we get a message "Some extra files found: 'input.rds'"
This is because when running
In particular 3. doesn't check for dependencies and so raises the "extra files" message. This doesn't happen for existing dependency test as that just copies the file over so that file is both the dependency and the artefact.
This PR will
usedby
anduses
queriesThere were a couple of ways we could have got the expected dependency info out, we also have it available in
custom_metadata
or could have read it out when reading the yml. Not sure what is most appropriate here so let me know if you want a bit of a different approach.