fix: pass var docblock comments by ref

After extracting into seperate method, var_comments weren't overriden.
vimeo · Feb 9, 2025 · 71d9de1 · 71d9de1
1 parent 9c48910
commit 71d9de1
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php
@@ -162,6 +162,7 @@ public static function analyze(
             $var_id,
             $assign_value_type,
             $doc_comment,
+            $var_comments,
             $comment_type,
             $comment_type_location,
             $not_ignored_docblock_var_ids,
@@ -596,6 +597,7 @@ private static function analyzeAssignment(
     }
 
     /**
+     * @return list<VarDocblockComment> $var_comment
      * @param list<string> $removed_taints
      */
     private static function analyzeDocComment(
@@ -606,6 +608,7 @@ private static function analyzeDocComment(
         ?string $var_id,
         ?Union $assign_value_type,
         ?Doc $doc_comment,
+        array &$var_comments,
         ?Union &$comment_type,
         ?DocblockTypeLocation &$comment_type_location,
         array $not_ignored_docblock_var_ids,