Use PHP_VERSION_ID instead of version_compare()

As we do elsewhere
vimeo · Mar 3, 2024 · 87e2af4 · 87e2af4
1 parent 64a3272
commit 87e2af4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/Traits/InvalidCodeAnalysisTestTrait.php b/tests/Traits/InvalidCodeAnalysisTestTrait.php
@@ -11,10 +11,9 @@
 use function strpos;
 use function strtoupper;
 use function substr;
-use function version_compare;
 
 use const PHP_OS;
-use const PHP_VERSION;
+use const PHP_VERSION_ID;
 
 /**
  * @psalm-type DeprecatedDataProviderArrayNotation = array{
@@ -53,7 +52,7 @@ public function testInvalidCode(
     ): void {
         $test_name = $this->getTestName();
         if (strpos($test_name, 'PHP80-') !== false) {
-            if (version_compare(PHP_VERSION, '8.0.0', '<')) {
+            if (PHP_VERSION_ID < 8_00_00) {
                 $this->markTestSkipped('Test case requires PHP 8.0.');
             }
 

diff --git a/tests/Traits/ValidCodeAnalysisTestTrait.php b/tests/Traits/ValidCodeAnalysisTestTrait.php
@@ -10,10 +10,9 @@
 use function strpos;
 use function strtoupper;
 use function substr;
-use function version_compare;
 
 use const PHP_OS;
-use const PHP_VERSION;
+use const PHP_VERSION_ID;
 
 trait ValidCodeAnalysisTestTrait
 {
@@ -44,15 +43,15 @@ public function testValidCode(
     ): void {
         $test_name = $this->getTestName();
         if (strpos($test_name, 'PHP80-') !== false) {
-            if (version_compare(PHP_VERSION, '8.0.0', '<')) {
+            if (PHP_VERSION_ID < 8_00_00) {
                 $this->markTestSkipped('Test case requires PHP 8.0.');
             }
 
             if ($php_version === null) {
                 $php_version = '8.0';
             }
         } elseif (strpos($test_name, 'PHP81-') !== false) {
-            if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            if (PHP_VERSION_ID < 8_01_00) {
                 $this->markTestSkipped('Test case requires PHP 8.1.');
             }