Skip to content

Commit

Permalink
Finalize
Browse files Browse the repository at this point in the history
  • Loading branch information
danog committed Nov 30, 2024
1 parent 12e5f79 commit 99ff70c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion bin/gen_callmap.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ function assertParameter(array &$normalizedEntry, ReflectionParameter $param): v
$expectedType = $param->getType();

if (isset($expectedType) && !empty($normalizedEntry['type'])) {
assertTypeValidity($expectedType, $normalizedEntry['type'], "Param '{$name}'");
$func = $param->getDeclaringFunction()->getName();
assertTypeValidity($expectedType, $normalizedEntry['type'], "Param $func '{$name}'");
}
}

Expand Down Expand Up @@ -159,6 +160,7 @@ function assertTypeValidity(ReflectionType $reflected, string &$specified, strin
$callMapType->removeType('null');
}
}
$specified = $callMapType->getId(true);
// //$this->assertSame($expectedType->hasBool(), $callMapType->hasBool(), "{$msgPrefix} type '{$specified}' missing bool from reflected type '{$reflected}'");
// $this->assertSame($expectedType->hasArray(), $callMapType->hasArray(), "{$msgPrefix} type '{$specified}' missing array from reflected type '{$reflected}'");
// $this->assertSame($expectedType->hasInt(), $callMapType->hasInt(), "{$msgPrefix} type '{$specified}' missing int from reflected type '{$reflected}'");
Expand Down

0 comments on commit 99ff70c

Please sign in to comment.