Skip to content

Commit

Permalink
Configure default baseline
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgsowa committed Feb 11, 2024
1 parent 10a53a2 commit dd985ca
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/Psalm/Internal/Cli/Psalm.php
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ private static function generateBaseline(
): array {
fwrite(STDERR, 'Writing error baseline to file...' . PHP_EOL);

$errorBaseline = ((string) $options['set-baseline']) ?: $config->error_baseline;
$errorBaseline = ((string) $options['set-baseline']) ?: $config->error_baseline ?: Config::DEFAULT_BASELINE_NAME;

Check failure on line 654 in src/Psalm/Internal/Cli/Psalm.php

View workflow job for this annotation

GitHub Actions / build

RiskyTruthyFalsyComparison

src/Psalm/Internal/Cli/Psalm.php:654:26: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)

try {
$issue_baseline = ErrorBaseline::read(
Expand All @@ -662,7 +662,6 @@ private static function generateBaseline(
$issue_baseline = [];
}

echo $errorBaseline;
ErrorBaseline::create(
new FileProvider,
$errorBaseline,
Expand All @@ -672,7 +671,7 @@ private static function generateBaseline(

fwrite(STDERR, "Baseline saved to $errorBaseline.");

if ($options['set-baseline'] && $options['set-baseline'] !== $config->error_baseline) {
if ($errorBaseline !== $config->error_baseline) {
CliUtils::updateConfigFile(
$config,
$path_to_config ?? $current_dir,
Expand Down

0 comments on commit dd985ca

Please sign in to comment.