Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enum cases to be global constants #10339

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Allow enum cases to be global constants #10339

merged 1 commit into from
Nov 3, 2023

Conversation

robchett
Copy link
Contributor

@robchett robchett commented Nov 2, 2023

fixes #10334

@robchett robchett force-pushed the global_const_as_enum_case branch from 55c71a1 to 97a7cf8 Compare November 2, 2023 14:13
@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Nov 3, 2023
@orklah
Copy link
Collaborator

orklah commented Nov 3, 2023

Thanks!

@orklah orklah merged commit e6564c6 into vimeo:master Nov 3, 2023
38 of 40 checks passed
@weirdan
Copy link
Collaborator

weirdan commented Feb 1, 2024

We probably should backport this to 5.x

@weirdan weirdan mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robchett @orklah @weirdan