Fix enum crash

[AegirLeet]

Fixes #10560.

First commit fixes the crash.

Second commit fixes the InvalidEnumCaseValue revealed once the crashing is fixed.

Third commit adds two test cases for the crash fix.

I'd like to add some more test cases to validate the value is resolved correctly, but not sure where.

[weirdan]

Does https://psalm.dev/r/38dc5a68ea (referencing the enum below rather than above) work with your PR?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/38dc5a68ea

<?php declare(strict_types=1);

enum AnotherEnum: string
{
    case ANOTHER_VALUE = SomeEnum::SOME_VALUE->value;
}

enum SomeEnum: string
{
    case SOME_VALUE = 'SOME_VALUE';
}

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/Reflector/ClassLikeNodeScanner.php: Failed to infer case value for ANOTHER_VALUE

[AegirLeet]

No, that still fails. Looks like the ClassLikeStorageProvider doesn't know about SomeEnum at that point. This seems to be a general issue with enums referencing things declared later. Seems to work fine with two classes and consts though (https://psalm.dev/r/5d409f074e).

I can look into it, but probably not before monday.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/5d409f074e

<?php

declare(strict_types=1);

class Foo
{
    public const BAR = Baz::QUX;
}

class Baz
{
    public const QUX = 123;
}

/** @psalm-trace $x */
$x = Foo::BAR;
echo $x;

Psalm output (using commit bf57d59):

INFO: Trace - 16:1 - $x: 123

[AegirLeet]

@weirdan Is this still needed with #10655?

[weirdan]

No, that PR addresses the issue you were trying to fix in a more general way.