Fix some more tests when running phpunit with args #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonE
force-pushed
the
fix-variadic-test-when-run-with-args
branch
from
469077b to
db4b0d9
Compare
MoonE
changed the title
e.g: ./vendor/bin/phpunit --filter 'Psalm\\Tests\\VariadicTest'
Call parent setUpBeforeClaass method instead of duplicating code. Use the VersionUtils class also in AsyncTest instead of hard-coded values.
MoonE
force-pushed
the
fix-variadic-test-when-run-with-args
branch
from
db4b0d9 to
e104983
Compare
orklah
added
the
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11122
Running this failed because of the argv values
./vendor/bin/phpunit --filter '/^Psalm\\Tests\\VariadicTest/'