[GH-11184] urlencode return an empty string when input is empty #11292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathroc
changed the title
orklah
reviewed
Feb 16, 2025
| @@ -50216,13 +50216,23 @@ | |||
| ), | |||
| 'rawurldecode' => | |||
| array ( | |||
| 0 => 'string', | |||
| 'string' => 'string', | |||
| 0 => '\'\'', | |||
There was a problem hiding this comment.
I'm not used to the new callmap format yet but the way I understand it, this is supposed to be the return type. Shouldn't that be string?
There was a problem hiding this comment.
I'm not sure of the format either, what I'm trying to do is tell that if the input is an empty string ('') the return type is an empty string too, and if the input is a non empty string, so is the output
I need to test it
There was a problem hiding this comment.
I guess that could work, even if we rarely go this precise in callmaps, however in this case you'll be missing the main case (you handle empty-string, non-empty-string but you should also handle any-string :p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.