Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to but not quite Issue #392 #394

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Related to but not quite Issue #392 #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34eac84
format integrish to stirp white space
vincentarelbundock Nov 22, 2024
81f9354
Merge branch 'main' into issue392
vincentarelbundock Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/format_numeric.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ format_numeric <- function(value, num_suffix, digits, num_mark_big, num_mark_dec
num_zero = num_zero,
num_fmt = num_fmt)
# integer
} else if (isTRUE(check_integerish(value)) && !is.null(digits)) {
} else if (isTRUE(check_integerish(value))) {
out <- format_integer(value,
digits = digits,
num_mark_big = num_mark_big,
Expand Down
8 changes: 4 additions & 4 deletions inst/tinytest/_tinysnapshot/html-missing_value.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@
<tbody>
<tr>
<td>-</td>
<td> 3</td>
<td>3</td>
</tr>
<tr>
<td> 1</td>
<td>1</td>
<td>-</td>
</tr>
<tr>
<td> 2</td>
<td> 5</td>
<td>2</td>
<td>5</td>
</tr>
</tbody>
</table>
Expand Down
6 changes: 3 additions & 3 deletions inst/tinytest/_tinysnapshot/typst-missing_value_replacement.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ block[ // start block
),

// tinytable cell content after
[-], [ 3],
[ 1], [-],
[ 2], [ 5],
[-], [3],
[1], [-],
[2], [5],

// tinytable footer after

Expand Down
Loading