Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List attrs test #165

Closed
wants to merge 6 commits into from
Closed

List attrs test #165

wants to merge 6 commits into from

Conversation

Jeroendevr
Copy link
Contributor

Regarding Issue #163 I have created it's test already. If we are going for option 5 off course. Good to hear your opinion by the weekend.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 94.04% // Head: 94.09% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a952ae0) compared to base (e03e7ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   94.04%   94.09%   +0.05%     
==========================================
  Files           6        6              
  Lines         537      542       +5     
==========================================
+ Hits          505      510       +5     
  Misses         32       32              
Impacted Files Coverage Δ
tests/test_dict2xml.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinitkumar
Copy link
Owner

@Jeroendevr I resolved the issue with CI. Please check the warnings by flake8. I see a lot of tests are failing because of that.

@Jeroendevr
Copy link
Contributor Author

Thanks for the feedback forgot about that one.😉 I fixed the flake8 ("long live trailing whitespace"). One unittest only fails right now because we need to find an implementation for the issue mentioned on #163

@vinitkumar
Copy link
Owner

@Jeroendevr Alright, let me see if I can come up with a good implementation for it this weekend. Thanks for the efforts :)

@vinitkumar
Copy link
Owner

@Jeroendevr Sorry, kid is sick, so I didn't find time to work on it this weekend.

@Jeroendevr
Copy link
Contributor Author

Jeroendevr commented Jan 9, 2023

No problem, hope the kid will be better soon. You also updated you photo, now with kid for proof? 😉 just kidding.

@vinitkumar
Copy link
Owner

vinitkumar commented Jan 9, 2023 via email

@Jeroendevr
Copy link
Contributor Author

Hopefully, the child is doing better already? Is it ok if I give my attempt at it or did you had time last week to work on it?

@vinitkumar
Copy link
Owner

vinitkumar commented Jan 17, 2023 via email

@Jeroendevr Jeroendevr mentioned this pull request Jan 17, 2023
@Jeroendevr
Copy link
Contributor Author

close this as it is fixed in #169

@Jeroendevr Jeroendevr closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants