-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List attrs test #165
List attrs test #165
Conversation
Codecov ReportBase: 94.04% // Head: 94.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 94.04% 94.09% +0.05%
==========================================
Files 6 6
Lines 537 542 +5
==========================================
+ Hits 505 510 +5
Misses 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@Jeroendevr I resolved the issue with CI. Please check the warnings by flake8. I see a lot of tests are failing because of that. |
Thanks for the feedback forgot about that one.😉 I fixed the flake8 ("long live trailing whitespace"). One unittest only fails right now because we need to find an implementation for the issue mentioned on #163 |
@Jeroendevr Alright, let me see if I can come up with a good implementation for it this weekend. Thanks for the efforts :) |
@Jeroendevr Sorry, kid is sick, so I didn't find time to work on it this weekend. |
No problem, hope the kid will be better soon. You also updated you photo, now with kid for proof? 😉 just kidding. |
Lol no. Thats a three year old picture.
On Tue, 10 Jan 2023 at 01:44, Jeroendevr ***@***.***> wrote:
No problem, hope the kid will be better soon. Also updated the photo for
proof? 😉 just kidding.
—
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDITRGTXXRAQRSB3P35KLWRRWSDANCNFSM6AAAAAATPZLCQM>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Thanks and Regards,
Vinit Kumar
|
Hopefully, the child is doing better already? Is it ok if I give my attempt at it or did you had time last week to work on it? |
Still not 100%. Go ahead with it, i will chip in when required
On Tue, 17 Jan 2023 at 15:03, Jeroendevr ***@***.***> wrote:
Hopefully, the child is doing better already? Is it ok if I give my
attempt at it or did you had time last week to work on it?
—
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDITTBLABBE6A7N2WU5ILWSZRNPANCNFSM6AAAAAATPZLCQM>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Thanks and Regards,
Vinit Kumar
|
close this as it is fixed in #169 |
Regarding Issue #163 I have created it's test already. If we are going for option 5 off course. Good to hear your opinion by the weekend.