-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information required for LSP features to Parse AST #764
Conversation
I really feel like the code is mixing things that should not be mixed. |
a5a8050
to
9a7b8e3
Compare
Alright @marcoeilers this is pretty much final and ready to be merged (will require some small changes of tests in the silicon repo) |
@marcoeilers baring any bugs this is now final |
4b11a8f
to
b8dfd93
Compare
I really don't understand why the carbon tests are failing though...
Like expected |
The problem seems to be that the reported error has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small questions and some comments that can be dropped
There are still some failing tests