-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scanpdf revisions and enhancements #4
Open
dkfurrow
wants to merge
15
commits into
virantha:master
Choose a base branch
from
dkfurrow:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not to be invoked, re-established test of blank_threshold value, implemented a deskew function in place of crop, changed post-process to do text recogniion on finished pdf (unpaper didn't work for me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Virantha;
I am a recent convert to linux, and I found your post of getting the one-touch scan enabled on scansnap enabled, and also the scanpdf project.
I found that some of the base commands (scan, unpaper) didn't work on my system (LM 18), so applied some small changes to get those functions working again. Also, I noticed the is_blank method wasn't applying the blank_threshold variable, so fixed that, as well as the application of the --face-up argument. Beyond that, I applied the following enhancements:
Anyway, this is my first contribution to a defined pip package, so I apologize in advance if I missed any documentation or package build steps...For example, It was a little unclear to me how I should include the wx requirement. Also, I wasn't sure what sort of tests to include, but I did add a simple run script with various options that I used in my own testing. In any case, I wanted to attempt to make a contribution here, since your original work was quite useful to me. If you have any questions or would like me to make further adjustments in my fork, my email is [email protected].
Thanks,
Dale