-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linespan support #7
base: master
Are you sure you want to change the base?
Conversation
Any updates on this? |
Yeah, he doesn't seem particularly interested in maintaining this. You may want to try emailing him, via his address in the AUTHORS file. |
Thanks for the contribution @bored-engineer ! phply is under new management now ;) |
Hey @viraptor that's great to hear! My apologies the Python 3 patches got mixed in here, wasn't my intention. |
@bored-engineer I'm just trying to process this patch and thinking of how to really handle linespans. As it is currently linespans will always belong to one token only. But that means that linespan of isset in:
is still (1,1). I guess I'd expect (1,3). Am I misunderstanding how this should work? Which version of behaviour would you expect? (merged temporarily in https://github.com/viraptor/phply/tree/linespan) |
Added the ability to exact the entire linespan for a tag, not just the line number.