Skip to content
Lint, check, clippy and test

Pallet Pass #16

Sign in to view logs

Pallet Pass

Pallet Pass #16

Triggered via pull request October 7, 2024 23:02
@pandres95pandres95
synchronize #22
pallet-pass
Status Success
Total duration 1m 21s
Artifacts –

ci.yml

on: pull_request
lint
4s
lint
check
28s
check
clippy
32s
clippy
test
1m 0s
test
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
using `map_err` over `inspect_err`: pallets/pass/src/lib.rs#L80
warning: using `map_err` over `inspect_err` --> pallets/pass/src/lib.rs:80:15 | 80 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 80 - #[pallet::pallet] 80 + #[pallet::&inspect_err] |
`self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect: traits/memberships/src/lib.rs#L98
warning: `self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect --> traits/memberships/src/lib.rs:98:14 | 98 | Self(self.0.saturating_sub(n.get()).max(Self::MIN.0)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.saturating_sub(n.get())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default
using `map_err` over `inspect_err`: pallets/referenda-tracks/src/lib.rs#L93
warning: using `map_err` over `inspect_err` --> pallets/referenda-tracks/src/lib.rs:93:15 | 93 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 93 - #[pallet::pallet] 93 + #[pallet::&inspect_err] |
using `map_err` over `inspect_err`: pallets/gas-transaction-payment/src/lib.rs#L32
warning: using `map_err` over `inspect_err` --> pallets/gas-transaction-payment/src/lib.rs:32:15 | 32 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 32 - #[pallet::pallet] 32 + #[pallet::&inspect_err] |
using `map_err` over `inspect_err`: pallets/template/src/lib.rs#L34
warning: using `map_err` over `inspect_err` --> pallets/template/src/lib.rs:34:15 | 34 | #[pallet::pallet] | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 34 - #[pallet::pallet] 34 + #[pallet::&inspect_err] |
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/