fix: [Traits for Authn] UserAuthenticator MUST verify credentials, not just let them validate themselves
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot just by themselves
pandres95
force-pushed
the
fix/user-authenticator-must-verify-credentials-not-just-let-them-verify-themselves
branch
from
4419e7c to
f588a50
Compare
olanod
approved these changes
Oct 13, 2024
olanod
deleted the
fix/user-authenticator-must-verify-credentials-not-just-let-them-verify-themselves
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a finding where, if a
credentialis valid, the authentication passes as long as the challenge can be validated by adevice-credentialpair.Since
credentials validate themselves, an instance of theUserAuthenticator(a.k.a. adevice) has no way to know whether thatcredentialis in some way bound to thedeviceIi.e. a way to know whether acredentialwas issued by thedevice, or more specifically, whether it was signed by it).This Pull Request resolves such issue, enforcing credentials to be verified by the device.