Skip to content
Lint, check, clippy and test

Pallet Pass #5

Sign in to view logs

Pallet Pass

Pallet Pass #5

GitHub Actions / clippy failed Sep 27, 2024 in 0s

clippy

2 errors, 15 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 15
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check failure on line 23 in pallets/pass/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no variant or associated item named `Success` found for enum `pallet::Event` in the current scope 

error[E0599]: no variant or associated item named `Success` found for enum `pallet::Event` in the current scope
  --> pallets/pass/src/benchmarking.rs:23:39
   |
23 |         assert_last_event::<T>(Event::Success.into());
   |                                       ^^^^^^^ variant or associated item not found in `Event<_, _>`
   |
  ::: pallets/pass/src/lib.rs:84:5
   |
84 |     pub enum Event<T: Config<I>, I: 'static = ()> {
   |     --------------------------------------------- variant or associated item `Success` not found for this enum

Check failure on line 23 in pallets/pass/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function takes 2 generic arguments but 1 generic argument was supplied 

error[E0107]: function takes 2 generic arguments but 1 generic argument was supplied
  --> pallets/pass/src/benchmarking.rs:23:9
   |
23 |         assert_last_event::<T>(Event::Success.into());
   |         ^^^^^^^^^^^^^^^^^   - supplied 1 generic argument
   |         |
   |         expected 2 generic arguments
   |
note: function defined here, with 2 generic parameters: `T`, `I`
  --> pallets/pass/src/benchmarking.rs:7:4
   |
7  | fn assert_last_event<T: Config<I>, I: 'static>(generic_event: <T as Config<I>>::RuntimeEvent) {
   |    ^^^^^^^^^^^^^^^^^ -             -
help: add missing generic argument
   |
23 |         assert_last_event::<T, I>(Event::Success.into());
   |                              +++

Check warning on line 34 in pallets/template/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/template/src/lib.rs:34:15
   |
34 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
34 -     #[pallet::pallet]
34 +     #[pallet::&inspect_err]
   |

Check warning on line 98 in traits/memberships/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect 

warning: `self.0.saturating_sub(n.get())` is never smaller than `Self::MIN.0` and has therefore no effect
  --> traits/memberships/src/lib.rs:98:14
   |
98 |         Self(self.0.saturating_sub(n.get()).max(Self::MIN.0))
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.0.saturating_sub(n.get())`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max
   = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default

Check warning on line 1 in pallets/template/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

duplicated attribute 

warning: duplicated attribute
  --> pallets/template/src/benchmarking.rs:1:8
   |
1  | #![cfg(feature = "runtime-benchmarks")]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first defined here
  --> pallets/template/src/lib.rs:10:7
   |
10 | #[cfg(feature = "runtime-benchmarks")]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: remove this attribute
  --> pallets/template/src/benchmarking.rs:1:8
   |
1  | #![cfg(feature = "runtime-benchmarks")]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes
   = note: `#[warn(clippy::duplicated_attributes)]` on by default

Check warning on line 93 in pallets/referenda-tracks/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/referenda-tracks/src/lib.rs:93:15
   |
93 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
93 -     #[pallet::pallet]
93 +     #[pallet::&inspect_err]
   |

Check warning on line 86 in pallets/referenda-tracks/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty doc comment 

warning: empty doc comment
  --> pallets/referenda-tracks/src/lib.rs:86:9
   |
86 |         ///
   |         ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `#[warn(clippy::empty_docs)]` on by default

Check warning on line 96 in pallets/referenda-tracks/src/impls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `()` 

warning: useless conversion to the same type: `()`
  --> pallets/referenda-tracks/src/impls.rs:96:12
   |
96 |         Ok(().into())
   |            ^^^^^^^^^ help: consider removing `.into()`: `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 96 in pallets/referenda-tracks/src/impls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

passing a unit value to a function 

warning: passing a unit value to a function
  --> pallets/referenda-tracks/src/impls.rs:96:9
   |
96 |         Ok(().into())
   |         ^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
   = note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
   |
96 ~         ().into();
97 +         Ok(())
   |

Check warning on line 32 in pallets/gas-transaction-payment/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/gas-transaction-payment/src/lib.rs:32:15
   |
32 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
32 -     #[pallet::pallet]
32 +     #[pallet::&inspect_err]
   |

Check warning on line 41 in pallets/referenda-tracks/src/impls.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

binary comparison to literal `Option::None` 

warning: binary comparison to literal `Option::None`
  --> pallets/referenda-tracks/src/impls.rs:41:13
   |
41 |             Tracks::<T, I>::get(id) == None,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `Tracks::<T, I>::get(id).is_none()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
   = note: `#[warn(clippy::partialeq_to_none)]` on by default

Check warning on line 86 in pallets/referenda-tracks/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait 

warning: using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait
  --> pallets/referenda-tracks/src/benchmarking.rs:86:57
   |
86 |         OriginToTrackId::<T, I>::insert(origin.clone(), id.clone());
   |                                                         ^^^^^^^^^^ help: try dereferencing it: `*id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 85 in pallets/referenda-tracks/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait 

warning: using `clone` on type `<T as Config<I>>::TrackId` which implements the `Copy` trait
  --> pallets/referenda-tracks/src/benchmarking.rs:85:32
   |
85 |         Tracks::<T, I>::insert(id.clone(), track.clone());
   |                                ^^^^^^^^^^ help: try dereferencing it: `*id`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 120 in pallets/gas-transaction-payment/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `DispatchInfo` which implements the `Copy` trait 

warning: using `clone` on type `DispatchInfo` which implements the `Copy` trait
   --> pallets/gas-transaction-payment/src/extensions.rs:120:22
    |
120 |                     &info.clone().into(),
    |                      ^^^^^^^^^^^^ help: try dereferencing it: `(*info)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 120 in pallets/gas-transaction-payment/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `frame_support::dispatch::DispatchInfo` 

warning: useless conversion to the same type: `frame_support::dispatch::DispatchInfo`
   --> pallets/gas-transaction-payment/src/extensions.rs:120:22
    |
120 |                     &info.clone().into(),
    |                      ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `info.clone()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 20 in pallets/referenda-tracks/src/benchmarking.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

duplicated attribute 

warning: duplicated attribute
  --> pallets/referenda-tracks/src/benchmarking.rs:20:8
   |
20 | #![cfg(feature = "runtime-benchmarks")]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first defined here
  --> pallets/referenda-tracks/src/lib.rs:37:7
   |
37 | #[cfg(feature = "runtime-benchmarks")]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: remove this attribute
  --> pallets/referenda-tracks/src/benchmarking.rs:20:8
   |
20 | #![cfg(feature = "runtime-benchmarks")]
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes
   = note: `#[warn(clippy::duplicated_attributes)]` on by default

Check warning on line 102 in pallets/gas-transaction-payment/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant pattern matching, consider using `is_some()` 

warning: redundant pattern matching, consider using `is_some()`
   --> pallets/gas-transaction-payment/src/extensions.rs:102:16
    |
102 |         if let Some(_) = T::GasBurner::check_available_gas(who, &info.weight) {
    |         -------^^^^^^^------------------------------------------------------- help: try: `if T::GasBurner::check_available_gas(who, &info.weight).is_some()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
View more details on GitHub Actions