Skip to content

fix(fc-pallet-pass): invalid data handling for extension Pre

Sign in for the full log view
GitHub Actions / clippy succeeded Nov 19, 2024 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511e 2024-10-15)

Annotations

Check warning on line 93 in pallets/referenda-tracks/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/referenda-tracks/src/lib.rs:93:15
   |
93 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
93 -     #[pallet::pallet]
93 +     #[pallet::&inspect_err]
   |

Check warning on line 83 in pallets/pass/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/pass/src/lib.rs:83:15
   |
83 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
83 -     #[pallet::pallet]
83 +     #[pallet::&inspect_err]
   |

Check warning on line 198 in pallets/pass/src/extension.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> pallets/pass/src/extension.rs:198:27
    |
198 |             .pre_dispatch(&who, call, info, len)
    |                           ^^^^ help: change this to: `who`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 199 in pallets/pass/src/extension.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure 

warning: redundant closure
   --> pallets/pass/src/extension.rs:199:18
    |
199 |             .map(|pre| Some(pre))
    |                  ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Some`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 183 in pallets/pass/src/extension.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> pallets/pass/src/extension.rs:183:25
    |
183 |         self.0.validate(&who, call, info, len)
    |                         ^^^^ help: change this to: `who`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 181 in traits/authn/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `bool` which implements the `Copy` trait 

warning: using `clone` on type `bool` which implements the `Copy` trait
   --> traits/authn/src/util.rs:181:18
    |
181 |             Self(self.0.clone(), PhantomData)
    |                  ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 169 in traits/authn/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `bool` which implements the `Copy` trait 

warning: using `clone` on type `bool` which implements the `Copy` trait
   --> traits/authn/src/util.rs:169:18
    |
169 |             Self(self.0.clone(), PhantomData)
    |                  ^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.0`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 34 in pallets/template/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/template/src/lib.rs:34:15
   |
34 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
34 -     #[pallet::pallet]
34 +     #[pallet::&inspect_err]
   |

Check warning on line 32 in pallets/gas-transaction-payment/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `map_err` over `inspect_err` 

warning: using `map_err` over `inspect_err`
  --> pallets/gas-transaction-payment/src/lib.rs:32:15
   |
32 |     #[pallet::pallet]
   |               ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` on by default
help: try
   |
32 -     #[pallet::pallet]
32 +     #[pallet::&inspect_err]
   |
View more details on GitHub Actions