Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

feature(serializer): support encoding for number primitives under Compact<T> #7

Merged
merged 8 commits into from
Dec 21, 2022

Conversation

pandres95
Copy link
Member

No description provided.

src/serializer.rs Outdated Show resolved Hide resolved
src/serializer.rs Outdated Show resolved Hide resolved
@pandres95 pandres95 requested a review from olanod December 14, 2022 01:40
@pandres95 pandres95 force-pushed the feature/encode-compact branch from 8c16092 to d5b3a26 Compare December 14, 2022 04:43
Copy link
Member

@olanod olanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change I suggested before of using match instead of matches :)
Something that would be left is replacing the codec dependency to correctly compile with --no-default-features and some tests of course ;)

@pandres95 pandres95 requested a review from olanod December 20, 2022 21:29
@olanod olanod force-pushed the feature/encode-compact branch from 9df769f to 95f89cb Compare December 21, 2022 08:24
@olanod olanod merged commit cc3ae2a into virto-network:main Dec 21, 2022
@olanod
Copy link
Member

olanod commented Dec 21, 2022

@pandres95 I created #8 to track removing the dependency on scale-codec

@pandres95 pandres95 deleted the feature/encode-compact branch December 21, 2022 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants