Upgrade h2 and fix DBURL #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade h2 version from 1.3.169 to 1.4.196 - With the new version, a DBURL implicitly relative to cwd is no longer accepted, so use an explicit "./" instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor patch to upgrade h2 in grida-server, to prepare upcoming changes. I prefer to separate it from the rest so that it stands out :
H2DAOFactory.java:DriverManager.getConnection()was now failing with :The simplest fix just consists in making the relative path explicit with an extra "./" in DBURL. This extra constraint appears entirely related to the lib version upgrade, and a quick search for
jdbc:h2in the rest of the codebase shows that this h2 instance in Grida was likely the only one impacted by this change : all other h2 file paths in other VIP projects seem to be absolute.