Custom properties vip:dot #480
Conversation
|
Fine for me, too, thank you. |
verify if vip:dot values are one of the inputs
getter-setter for VipDotResultDir
intelligence to put result dir in dot or cross
parse vip:dot-result-directory
| @@ -38,6 +41,8 @@ public class BoutiquesApplication implements IsSerializable { | |||
| private Set<BoutiquesOutputFile> outputFiles = new HashSet<>(); | |||
| private Map<String, String> tags = new HashMap<>(); | |||
| private String jsonFile; | |||
| private Set<String> vipDotInputIds; | |||
| private String resultDirs; | |||
There was a problem hiding this comment.
rename field and getter/setter with vipDotIncludesResultsDir, and change type to boolean.
There was a problem hiding this comment.
changed to boolean vipDotIncludesResultsDir
| application.setVipContainer(vipImagePath); | ||
| application.setVipContainer(getStringValue(customObject, "vip:imagepath", true)); | ||
| application.setVipDotInputIds(getArrayValueAsStringSet(customObject, "vip:dot", true)); | ||
| application.setVipDotResultDirs(getStringValue(customObject, "vip:dot-result-directory", true)); |
There was a problem hiding this comment.
Rename to vip:dot-with-results-directory.
Adapt to vip:dot-result-directory being a boolean.
There was a problem hiding this comment.
change to vip:dot-with-results-directory and adapt to the method getBooleanValue
| Set<String> incorrectInputs = new HashSet<>(vipDotInputIds); | ||
| incorrectInputs.removeAll(inputIds); | ||
| String warningMessage = "<b>" + String.join(", ", incorrectInputs) + "</b> appears in vipDotInputIds but not in inputs. Please ensure all ids are correct."; | ||
| Layout.getInstance().setWarningMessage(warningMessage); |
There was a problem hiding this comment.
in this case, it should be a error with an exception thrown.
There was a problem hiding this comment.
throwing ApplicationImporterException
| } | ||
|
|
||
| // Extract the IDs from inputs | ||
| Set<String> inputIds = application.getInputs().stream().map(BoutiquesInput::getId).collect(Collectors.toSet()); |
There was a problem hiding this comment.
You may add this as a BoutiquesApplication method. (optionally)
There was a problem hiding this comment.
Added the getinputIds method to BoutiquesApplication
| <source name="$input.getId()" type="string" optional="$input.isOptional()" default="$input.getDefaultValue()" vip-type-restriction="flag" pretty-name="$input.getName()"> | ||
| #else | ||
| <source name="$input.getId()" type="string" optional="$input.isOptional()" default="false" vip-type-restriction="flag" pretty-name="$input.getName()"> | ||
| #foreach( $input in $tool.getInputs() ) |
There was a problem hiding this comment.
I thnk VS or something else changed the indentation of velocity code and it generetad a lot of diff.
Could it be possible to keep the original indentation ?
There was a problem hiding this comment.
indeed, restore original indentation.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ava/fr/insalyon/creatis/vip/application/client/bean/boutiquesTools/BoutiquesApplication.java
Fixed
Show fixed
Hide fixed
Changes in VIP-portal regarding custom properties
Custom dot inputs
Handling of Command Line Flag Inputs