-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build warnings #511
Merged
axlbonnet
merged 3 commits into
virtual-imaging-platform:develop
from
ngeorges-cnrs:java21_warnings
Dec 11, 2024
Merged
Fix build warnings #511
axlbonnet
merged 3 commits into
virtual-imaging-platform:develop
from
ngeorges-cnrs:java21_warnings
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated PathMatchConfigurer. setUseSuffixPatternMatch(false) is now the default in Spring, cf https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/servlet/config/annotation/PathMatchConfigurer.html#isUseSuffixPatternMatch()). - Replace deprecated ReaderInputStream with ReaderInputStream.builder() - Replace deprecated XMLReaderFactory with SAXParserFactory - Replace deprecated Integer(string) with Integer.parseInt(string) - Replace deprecated URL() constructor with URI().toURL() - Replace deprecated string-based Runtime.getRuntime().exec() with its array-based variant - Add @SuppressWarnings("unchecked") in all places with an "unchecked" warning. This is not ideal but we lack of a better alternative.
...lication/src/main/java/fr/insalyon/creatis/vip/application/client/view/monitor/StatsTab.java
Fixed
Show resolved
Hide resolved
axlbonnet
reviewed
Dec 10, 2024
...ment/src/main/java/fr/insalyon/creatis/vip/datamanager/server/rpc/FileUploadServiceImpl.java
Outdated
Show resolved
Hide resolved
...lication/src/main/java/fr/insalyon/creatis/vip/application/client/view/monitor/StatsTab.java
Fixed
Show resolved
Hide resolved
...tion/src/main/java/fr/insalyon/creatis/vip/application/server/business/ReproVipBusiness.java
Show resolved
Hide resolved
...c/test/java/fr/insalyon/creatis/vip/application/integrationtest/PublicApplicationListIT.java
Outdated
Show resolved
Hide resolved
vip-api/src/main/java/fr/insalyon/creatis/vip/api/business/DataApiBusiness.java
Show resolved
Hide resolved
vip-api/src/main/java/fr/insalyon/creatis/vip/api/business/PipelineBusiness.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/fr/insalyon/creatis/vip/application/server/rpc/WorkflowServiceImpl.java
Outdated
Show resolved
Hide resolved
vip-portal/src/test/java/fr/insalyon/creatis/applicationimporter/GwendiaTemplateTest.java
Outdated
Show resolved
Hide resolved
- Remove useless import ParserConfigurationException *2 - Remove useless onChanged handler in vip-application StatsTab.java (no-op method, was causing a PMD warning in CI) - Replace unchecked suppression with better alternative in PublicApplicationListIT.java - Throw ParserConfigurationException in GwendiaTemplateTest.java
Remove unchecked suppression by: - Replacing JakartaServletFileUpload with JakartaServletDiskFileUpload - Replaceing FileItem with DiskFileItem And also replace the iterator by a for loop.
@axlbonnet :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes all build warnings under Intellij+Maven with java21. No functional change.