Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script #32

Open
wants to merge 109 commits into
base: main
Choose a base branch
from
Open

Release script #32

wants to merge 109 commits into from

Conversation

ravikiran2020
Copy link
Contributor

New branch is created from dev branch named it as release-script. Only deployment-release workflow is present in this branch.

Copy link
Contributor

@raj-vlabs raj-vlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ravikiran, I understand you have only made changes to the workflow. You can ignore other comments and just work on the one on the workflow.

contents: read

jobs:
build-and-deploy:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have build and deploy as 2 separate jobs with deploy dependent on build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raj-vlabs 2 separate jobs created for build and deploy. Deploy is dependent on build.
Please check

@@ -31,6 +31,8 @@
"font-awesome": "^4.7.0",
"fuse.js": "^6.6.2",
"googleapis": "^118.0.0",
"jquery": "npm:jQuery@^1.7.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need a jQuery dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants