Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change timeout invocation to support breaking change #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertp-indeed
Copy link

In busybox commit c9720a761, a breaking change was introduced that
removes the -t flag to timeout in favor of just taking the time as
the second arg, bringing it in line with coreutils' timeout. This
commit was included in tag 1.31.1, released on 25 Oct, 2019, at
which point my integration tests that spin up a server using wait-for-it
started to fail.

Fixes #82 .

In busybox commit [c9720a761][], a breaking change was introduced that
removes the `-t` flag to `timeout` in favor of just taking the time as
the second arg, bringing it in line with coreutils' `timeout`. This
commit was included in tag [1.31.1][], released on 25 Oct, 2019, at
which point my integration tests that spin up a server using wait-for-it
started to fail.

[c9720a761]: mirror/busybox@c9720a7
[1.31.1]: https://github.com/mirror/busybox/releases/tag/1_31_1
@skinofstars
Copy link

My CI was also been failing for the same reason. This has resolved the issue.

@kolomenkin
Copy link
Contributor

looks too early to drop support of Alpine immediately after new version release.
I would expect to keep support of old Alpine/Busybox for at least few years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change to busybox's timeout causes wait-for-it to fail
3 participants