Adapt the printed remaining time granularity when it is very high #63
Comments
|
yeah, good idea |
|
Could through the ms module in: link. |
Closed
|
@jdan I use ms module to implement :) Can someone test the code ? On my tests all its working fine. |
|
@hallas can you check the pull request? |
|
Hey @marceloboeira Sorry .. I will.. Been very busy lately |
|
@hallas no worries man 👍 |
myndzi
pushed a commit
to myndzi/node-progress
that referenced
this issue
May 18, 2015
…, e.g. { 's': 1, 'm': 60, 'h': 3600 }
Modify ETA estimation to return the least granular unit for which the eta is >= 1, based on supplied values
Add replacement token ':unit', returns the label associated with the unit value
ProgressBar.defaultUnits holds the h/m/s arrangement; it is not actually used by default to preserve compatibility
Example usage: new ProgressBar(':eta:unit', { units: ProgressBar.defaultUnits });
Example output: '12.3m' -> '38.5s' (changes from minutes to seconds over time)
Addresses visionmedia#63
myndzi
pushed a commit
to myndzi/node-progress
that referenced
this issue
May 18, 2015
…, e.g. { 's': 1, 'm': 60, 'h': 3600 }
Modify ETA estimation to return the least granular unit for which the eta is >= 1, based on supplied values
Add replacement token ':unit', returns the label associated with the unit value
ProgressBar.defaultUnits holds the h/m/s arrangement; it is not actually used by default to preserve compatibility
Example usage: new ProgressBar(':eta:unit', { units: ProgressBar.defaultUnits });
Example output: '12.3m' -> '38.5s' (changes from minutes to seconds over time)
Addresses visionmedia#63
|
Reviews are coming very soon! :-) |
|
0/ |
|
Why exactly was this never implemented, I am seeing three pull-requests but none got accepted. There is still a need for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a data importer and for big files, the remaining time reaches a high amount of seconds (>100'000). That makes the timing tough to estimate.
When the timing reaches say more than 5 minutes, would it be possible to display the time in minutes ? Same for minutes to hours and hours to days ?
reference: senecajs-labs/seneca-import-csv#1
The text was updated successfully, but these errors were encountered: