Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging query pick global element #20156

Merged
merged 3 commits into from
Dec 23, 2024
+117 −4
Merged

Fix logging query pick global element #20156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3078f41
Fix how use_global_id query parameter is retrieved.
biagas Dec 19, 2024
edcf29b
Add release notes for 3.5.0.
biagas Dec 19, 2024
6747b50
Merge branch 'develop' into bugfix/biagas/fix_logging_query_pick_glob…
biagas Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions src/resources/help/en_US/relnotes3.5.0.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
<!doctype html public "-//w3c//dtd html 4.0 transitional//en">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta http-equiv="Content-Language" content="en-us">
<meta name="GENERATOR" content="Microsoft FrontPage 5.0">
<meta name="ProgId" content="FrontPage.Editor.Document">
<title>VisIt 3.5 Release Notes</title>
</head>
<body>


<center><b><font size="6">VisIt 3.5 Release Notes</font></b></center>

<p>Welcome to VisIt's release notes page. This page describes the important
enhancements and bug-fixes that were added to this release.</p>

<p><b>Sections</b></p>
<ul>
<li><a href="#General_features">Features for all users</a></li>
<li><a href="#Advanced_features">Features for advanced users</a></li>
<li><a href="#GUI_changes">Changes in GUI behavior</a></li>
<li><a href="#File_format">Changes to file format readers</a></li>
<li><a href="#Plot_changes">Changes to plots</a></li>
<li><a href="#Operator_changes">Changes to operators</a></li>
<li><a href="#Expression_changes">Changes to expressions</a></li>
<li><a href="#Query_changes">Changes to picks and queries</a></li>
<li><a href="#Bugs_fixed">Other bug fixes</a></li>
<li><a href="#Build_features">Changes to build_visit</a></li>
<li><a href="#Dev_changes">Changes for VisIt developers</a></li>
</ul>

<a name="General_features"></a>
<p><b><font size="4">General features added in version 3.5</font></b></p>
<ul>
<li>Added command recording for Annotation Objects.</li>
<li>General Feature 2</li>
</ul>

<a name="Advanced_features"></a>
<p><b><font size="4">Advanced features added in version 3.5</font></b></p>
<ul>
<li>Advanced Feature 1</li>
<li>Advanced Feature 2</li>
</ul>

<a name="GUI_changes"></a>
<p><b><font size="4">Changes in GUI behavior for version 3.5</font></b></p>
<ul>
<li>GUI Change 1</li>
<li>GUI Change 2</li>
</ul>

<a name="File_format"></a>
<p><b><font size="4">File format reader changes in version 3.5</font></b></p>
<ul>
<li>File Format 1</li>
<li>File Format 2</li>
</ul>

<a name="Plot_changes"></a>
<p><b><font size="4">Changes to VisIt's plots in version 3.5</font></b></p>
<ul>
<li>Plot Change 1</li>
<li>Plot Change 2</li>
</ul>

<a name="Operator_changes"></a>
<p><b><font size="4">Changes to VisIt's operators in version 3.5</font></b></p>
<ul>
<li>Operator Change 1</li>
<li>Operator Change 2</li>
</ul>

<a name="Expression_changes"></a>
<p><b><font size="4">Changes to VisIt's expression language in version 3.5</font></b></p>
<ul>
<li>Expression Change 1</li>
<li>Expression Change 2</li>
</ul>

<a name="Query_changes"></a>
<p><b><font size="4">Changes to VisIt's picks and queries in version 3.5</font></b></p>
<ul>
<li>Query Change 1</li>
<li>Query Change 2</li>
</ul>

<a name="Bugs_fixed"></a>
<p><b><font size="4">Other bugs fixed in version 3.5</font></b></p>
<ul>
<li>Fixed command recording for a Pick query with global element.</li>
<li>Bug Fix 2</li>
</ul>

<a name="Build_features"></a>
<p><b><font size="4">Changes to build_visit in version 3.5</font></b></p>
<ul>
<li>Removed support for VTK-8.</li>
<li>Build Feature 2</li>
</ul>

<a name="Dev_changes"></a>
<p><b><font size="4">Changes for VisIt developers in version 3.5</font></b></p>
<ul>
<li>Developer Change 1</li>
<li>Developer Change 2</li>
</ul>

<p>Click the following link to view the release notes for the previous version
of VisIt: <a href=relnotes3.4.2.html>3.4.2</a>.</p>
</body>
</html>
8 changes: 4 additions & 4 deletions src/visitpy/common/Logging.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,19 +1356,19 @@ static std::string log_QueryRPC(ViewerRPC *rpc)
qn = "NodePick";
else if (pt == "DomainZone")
{
bool global = false;
int global = 0;
if (queryParams.HasNumericEntry("use_global_id"))
global = queryParams.GetEntry("use_global_id")->ToBool();
global = queryParams.GetEntry("use_global_id")->ToInt();
if (global)
qn = "PickByGlobalZone";
else
qn = "PickByZone";
}
else if (pt == "DomainNode")
{
bool global = false;
int global = 0;
if (queryParams.HasNumericEntry("use_global_id"))
global = queryParams.GetEntry("use_global_id")->AsBool();
global = queryParams.GetEntry("use_global_id")->AsInt();
if (global)
qn = "PickByGlobalNode";
else
Expand Down