Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests #11

Merged
merged 3 commits into from
Jul 16, 2019
Merged

New tests #11

merged 3 commits into from
Jul 16, 2019

Conversation

Thomaash
Copy link
Member

Before:

=============================== Coverage summary ===============================
Statements   : 52.24% ( 291/557 )
Branches     : 54.03% ( 248/459 )
Functions    : 48.19% ( 40/83 )
Lines        : 52.75% ( 288/546 )
================================================================================

After:

=============================== Coverage summary ===============================
Statements   : 57.81% ( 322/557 )
Branches     : 57.52% ( 264/459 )
Functions    : 54.22% ( 45/83 )
Lines        : 58.06% ( 317/546 )
================================================================================

Thomaash added 3 commits July 16, 2019 19:52
@Thomaash
Add some dependencies for TS tests
3097f3e
@Thomaash
Fix copyArray type
05f1074 
It works on ro array just fine, so respect this in the type.
@Thomaash
Add some tests
ae27b38
mojoaxel
mojoaxel approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Good! Thanks!

@mojoaxel mojoaxel merged commit 5cfe425 into visjs:master Jul 16, 2019
@mojoaxel
Copy link
Member

this improves #6

@Thomaash Thomaash deleted the new-tests branch July 16, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojoaxel mojoaxel mojoaxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomaash @mojoaxel