-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching from RestClient to Faraday #53
Conversation
…t implementation of BasicAuth
I am trying to regenerate the VCR cassettes with the Faraday version (necessary because Faraday uses headers for BasicAuth, not url). However, I'm having a hard time trying to set up the SampleService on my Window Server 8 virtual box. If anyone has that SampleService running and could record the cassettes with code in 4ba5d7b, I'd be very much appreciative. |
I recorded new tapes, they are in https://github.com/visoft/ruby_odata/tree/new_vcr_tapes There are 6 errors with the features, but I didn't fix them because I wasn't sure if you were working on the same code. |
Any progress on this with the new tapes? |
@hungryzi Any progress on this using the new tapes? |
@@ -45,6 +45,9 @@ | |||
end | |||
|
|||
Then /^I should be able to call "([^\"]*)" on the service$/ do |method| | |||
require 'pry' | |||
binding.pry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed!
@visoft could you point me how to set up sample service with let's say virtualbox? |
Well first you need to install Windows. I have a Window 7 machine running under Parallels. From there, just get .NET installed. Once you have that, clone |
Awesome! On the other hand - did you ever think about moving from vcr? It's not very ruby way to install win7 with iis to re-record test if there's a need for that. I would advice to switch to fake service made with sinatra - take a look here |
@zzk, all the RSpec tests use that approach, using snapshots of the EDMX metadata and the result. They are completely isolated. The Cucumber features are more integration tests to ensure it works correctly with a live service. Of course these don't work using a CLI like Travis, hence the need for vcr. |
Closed because of #58 |
My main motivation is to add support to NTLM for my personal use and #12.
The secondary motivation is that Faraday looks better maintained than RestClient.
Faraday supports multiple adapters:
I plan to use Typhoeus(https://github.com/typhoeus/typhoeus).