Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests #78

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

KDGundermann
Copy link
Contributor

No description provided.

@visoft
Copy link
Owner

visoft commented Oct 10, 2017

Hey @KDGundermann, thanks for doing this, however, there is an error with the build. Specs pass ok, but it's trying to connect to 127.0.0.1:8989 when running Cucumber, take a look at Travis, but here's the pertinent part of the log:

Coverage report generated for RSpec to /home/travis/build/visoft/ruby_odata/coverage. 1261 / 1269 LOC (99.37%) covered.
/home/travis/.rvm/rubies/ruby-2.3.4/bin/ruby -S bundle exec cucumber features --format progress
/home/travis/.rvm/gems/ruby-2.3.4/gems/activesupport-3.0.20/lib/active_support/values/time_zone.rb:272: warning: circular argument reference - now
Connection refused - connect(2) for 127.0.0.1:8989 (Errno::ECONNREFUSED) (Faraday::ConnectionFailed)

Could you take a look?

@KDGundermann
Copy link
Contributor Author

Interesting, as I didn't touch any of the cucumber feature specs.
I see that Travis installs an ubuntu system for running the tests.
But how can the tests access the RubyODataService running on Windows with IIS on localhost ??

@visoft
Copy link
Owner

visoft commented Oct 10, 2017

You don't need to run the RubyODataService on Windows anymore. I used the VCR gem to record the responses for the Cucumber test, so now as long as VCR is working properly (this may be the problem with Travis) it will use the VCR cassette when Cucumber runs.

@KDGundermann
Copy link
Contributor Author

I'm sorry but I never used cucumber/pickle/vcr, its hard for me to fix the problem.

@visoft
Copy link
Owner

visoft commented Oct 12, 2017

No problem, I'll take a look at it when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants