Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force non-legacy import attributes babel output #386

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Nov 24, 2024

Description

So, what's happened is that @babel/plugin-syntax-import-attributes was necessary until quite recently, but it's now included in babel core since 7.26 https://babeljs.io/blog/2024/10/25/7.26.0#import-attributes-16579. Previously users would've seen more direct error message instead:

Add @babel/plugin-syntax-import-attributes (https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-import-attributes) to the 'plugins' section of your Babel config to enable parsing.

This monorepo had 7.25, so I actually got this error. For now, I updated @babel/core to make it work. I'll review pending renovate PR #373 since that includes @babel/core update too.

For user with version < 7.26, I assume generatorOpts.importAttributesKeyword would be no-op, so probably it's fine to always add it on our side.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hi-ogawa hi-ogawa marked this pull request as ready for review November 24, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin:vite:esbuild] Transform failed - Importing JSON files with { type: "json" };
2 participants