fix: force non-legacy import attributes babel output #386
+364
−818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So, what's happened is that
@babel/plugin-syntax-import-attributes
was necessary until quite recently, but it's now included in babel core since 7.26 https://babeljs.io/blog/2024/10/25/7.26.0#import-attributes-16579. Previously users would've seen more direct error message instead:This monorepo had 7.25, so I actually got this error. For now, I updated
@babel/core
to make it work. I'll review pending renovate PR #373 since that includes@babel/core
update too.For user with version < 7.26, I assume
generatorOpts.importAttributesKeyword
would be no-op, so probably it's fine to always add it on our side.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).