Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer links to check the docker images #107

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Use newer links to check the docker images #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions go/releaser/release/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,21 @@ func CheckDockerMessage(majorRelease int, repo string) []string {
"Make sure the Docker Images are being built by GitHub Actions.",
"This can be done by visiting the following links, our new release should appear in either green (done) or yellow (building / pending build):",
"",
fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_vttestserver.yml", repo),
}

// Hack: versions < v20 and versions >= v20 use different GitHub Actions workflows to build the Docker images.
if majorRelease < 20 {
msg = append(msg,
fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_vttestserver.yml", repo),
fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_base.yml", repo),
fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_lite.yml", repo),
)
} else {
} else if majorRelease == 20 {
msg = append(msg, fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_vttestserver.yml", repo))
msg = append(msg, fmt.Sprintf("\t- https://github.com/%s/actions/workflows/docker_build_images.yml", repo))
} else {
// this links to the newer GitHub Actions workflow that was introduced in v21 by https://github.com/vitessio/vitess/pull/16339
msg = append(msg, fmt.Sprintf("\t- https://github.com/%s/vitess/actions/workflows/build_docker_images.yml", repo))
}

return msg
Expand Down