Skip to content

Commit

Permalink
Update to latest Nodejs LTS and NPM
Browse files Browse the repository at this point in the history
This bumps to the latest Node LTS version with 22 and to NPM 11. Also
bumps Vite to the latest as well to address a Dependanbot alert.

Signed-off-by: Dirkjan Bussink <[email protected]>
  • Loading branch information
dbussink committed Jan 22, 2025
1 parent d1aa2f4 commit 0df7ff6
Show file tree
Hide file tree
Showing 11 changed files with 4,605 additions and 3,691 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check_make_vtadmin_web_proto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install npm dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static_checks_etc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
# make proto requires newer node than the pre-installed one
node-version: '20.12.2'
node-version: '22.13.1'

- name: check_make_proto
if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vtadmin_web_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
if: steps.skip-workflow.outputs.skip-workflow == 'false'
with:
# node-version should match package.json
node-version: '20.12.2'
node-version: '22.13.1'

- name: Install dependencies
if: steps.skip-workflow.outputs.skip-workflow == 'false'
Expand Down
4 changes: 2 additions & 2 deletions web/vtadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Prerequisites

- [node](https://nodejs.org) >= 20.12.0 LTS
- npm >= 10.5.0 (comes with node)
- [node](https://nodejs.org) >= 22.13.1 LTS
- npm >= 10.9.2 (comes with node)

## Available scripts

Expand Down
2 changes: 1 addition & 1 deletion web/vtadmin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if [[ -z ${NVM_DIR} ]]; then
fi

if [[ -z ${NODE_VERSION} ]]; then
export NODE_VERSION="20.12.2"
export NODE_VERSION="22.13.1"
fi

output "\nInstalling nvm...\n"
Expand Down
Loading

0 comments on commit 0df7ff6

Please sign in to comment.