Update Node version to current LTS release (#15822)

Signed-off-by: Matt Lord <[email protected]>
vitessio · Apr 30, 2024 · 2d11c93 · 2d11c93
1 parent ba0dfa4
commit 2d11c93
Show file tree

Hide file tree

Showing 13 changed files with 4,469 additions and 15,658 deletions.
diff --git a/.github/workflows/check_make_vtadmin_web_proto.yml b/.github/workflows/check_make_vtadmin_web_proto.yml
@@ -59,7 +59,7 @@ jobs:
       uses: actions/setup-node@v4
       with:
         # node-version should match package.json
-        node-version: '18.16.0'
+        node-version: '20.12.2'
 
     - name: Install npm dependencies
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.proto_changes == 'true'

diff --git a/.github/workflows/create_release.yml b/.github/workflows/create_release.yml
@@ -25,7 +25,7 @@ jobs:
     - name: Setup node
       uses: actions/setup-node@v4
       with:
-        node-version: '18.16.0'
+        node-version: '20.12.2'
 
     - name: Tune the OS
       run: |

diff --git a/.github/workflows/local_example.yml b/.github/workflows/local_example.yml
@@ -63,7 +63,7 @@ jobs:
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.examples == 'true'
       with:
         # node-version should match package.json
-        node-version: '18.16.0'
+        node-version: '20.12.2'
 
     - name: Tune the OS
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.examples == 'true'

diff --git a/.github/workflows/region_example.yml b/.github/workflows/region_example.yml
@@ -63,7 +63,7 @@ jobs:
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.examples == 'true'
       with:
         # node-version should match package.json
-        node-version: '18.16.0'
+        node-version: '20.12.2'
 
     - name: Tune the OS
       if: steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.examples == 'true'

diff --git a/.github/workflows/vtadmin_web_build.yml b/.github/workflows/vtadmin_web_build.yml
@@ -42,7 +42,7 @@ jobs:
         if: steps.skip-workflow.outputs.skip-workflow == 'false'
         with:
           # node-version should match package.json
-          node-version: '18.16.0'
+          node-version: '20.12.2'
 
       - name: Install dependencies
         if: steps.skip-workflow.outputs.skip-workflow == 'false'

diff --git a/.github/workflows/vtadmin_web_lint.yml b/.github/workflows/vtadmin_web_lint.yml
@@ -42,7 +42,7 @@ jobs:
         if: steps.skip-workflow.outputs.skip-workflow == 'false'
         with:
           # node-version should match package.json
-          node-version: '18.16.0'
+          node-version: '20.12.2'
 
       - name: Install dependencies
         if: steps.skip-workflow.outputs.skip-workflow == 'false'

diff --git a/.github/workflows/vtadmin_web_unit_tests.yml b/.github/workflows/vtadmin_web_unit_tests.yml
@@ -42,7 +42,7 @@ jobs:
         if: steps.skip-workflow.outputs.skip-workflow == 'false'
         with:
           # node-version should match package.json
-          node-version: '18.16.0'
+          node-version: '20.12.2'
 
       - name: Install dependencies
         if: steps.skip-workflow.outputs.skip-workflow == 'false'

diff --git a/changelog/20.0/20.0.0/summary.md b/changelog/20.0/20.0.0/summary.md
@@ -33,6 +33,8 @@
   - **[New Stats](#new-stats)**
     - [VTTablet Query Cache Hits and Misses](#vttablet-query-cache-hits-and-misses)
   - **[`SIGHUP` reload of gRPC client static auth creds](#sighup-reload-of-grpc-client-auth-creds)**
+  - **[VTAdmin](#vtadmin)**
+    - [Updated to node v20.12.2](#updated-node)
 
 ## <a id="major-changes"/>Major Changes
 
@@ -248,3 +250,10 @@ VTTablet exposes two new counter stats:
 ### <a id="sighup-reload-of-grpc-client-auth-creds"/>`SIGHUP` reload of gRPC client static auth creds
 
 The internal gRPC client now caches the static auth credentials and supports reloading via the `SIGHUP` signal. Previous to v20 the credentials were not cached. They were re-loaded from disk on every use.
+
+### <a id="vtadmin"/>VTAdmin
+
+#### <a id="updated-node"/>vtadmin-web updated to node v20.12.2 (LTS)
+
+Building `vtadmin-web` now requires node >= v20.12.0 (LTS). Breaking changes from v18 to v20 can be found at https://nodejs.org/en/blog/release/v20.12.0 -- with no known issues that apply to VTAdmin.
+Full details on the node v20.12.2 release can be found at https://nodejs.org/en/blog/release/v20.12.2.
diff --git a/web/vtadmin/README.md b/web/vtadmin/README.md
@@ -2,8 +2,8 @@
 
 ## Prerequisites
 
-- [node](https://nodejs.org) >= 18.16.0 LTS
-- npm >= 9.7.1 (comes with node)
+- [node](https://nodejs.org) >= 20.12.0 LTS
+- npm >= 10.5.0 (comes with node)
 
 ## Available scripts
 

diff --git a/web/vtadmin/build.sh b/web/vtadmin/build.sh
@@ -36,15 +36,15 @@ if [[ -z ${NVM_DIR} ]]; then
 fi
 
 if [[ -z ${NODE_VERSION} ]]; then
-    export NODE_VERSION="18.16.0"
+    export NODE_VERSION="20.12.2"
 fi
 
 output "\nInstalling nvm...\n"
 
 if [ -d "$NVM_DIR" ]; then
   output "\033[1;32mnvm is already installed!\033[0m"
 else
-  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash && output "\033[1;32mnvm is installed!\033[0m" || fail "\033[1;32mnvm failed to install!\033[0m"
+  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash && output "\033[1;32mnvm is installed!\033[0m" || fail "\033[1;32mnvm failed to install!\033[0m"
 fi
 
 source "$NVM_DIR/nvm.sh"