Fix flakiness in TestReadTransactionStatus (#17277)

Signed-off-by: Manan Gupta <[email protected]>

.github/CODEOWNERS

@@ -28,6 +28,7 @@ go.sum @ajm188 @deepthi @harshit-gangal @mattlord @rohit-nayak-ps @systay @froui
 /go/test/endtoend/onlineddl @rohit-nayak-ps @shlomi-noach
 /go/test/endtoend/messaging @mattlord @rohit-nayak-ps @derekperkins
 /go/test/endtoend/schemadiff @shlomi-noach @mattlord
+/go/test/endtoend/transaction @harshit-gangal @systay @frouioui @GuptaManan100
 /go/test/endtoend/*throttler* @shlomi-noach @mattlord @timvaillancourt
 /go/test/endtoend/vtgate @harshit-gangal @systay @frouioui
 /go/test/endtoend/vtorc @deepthi @shlomi-noach @GuptaManan100 @timvaillancourt

go/test/endtoend/transaction/twopc/twopc_test.go

@@ -1395,8 +1395,6 @@ func TestReadTransactionStatus(t *testing.T) {
 		"insert into twopc_t1(id, col) values(6, 4)",
 		"insert into twopc_t1(id, col) values(9, 4)",
 	})
-	// Allow enough time for the commit to have started.
-	time.Sleep(1 * time.Second)
 
 	// Create a tablet manager client and use it to read the transaction state.
 	tmc := grpctmclient.NewClient()
@@ -1405,12 +1403,24 @@ func TestReadTransactionStatus(t *testing.T) {
 	defer cancel()
 
 	primaryTablet := getTablet(clusterInstance.Keyspaces[0].Shards[2].FindPrimaryTablet().GrpcPort)
+	// Wait for the transaction to show up in the unresolved list.
 	var unresTransaction *querypb.TransactionMetadata
-	for _, shard := range clusterInstance.Keyspaces[0].Shards {
-		urtRes, err := tmc.GetUnresolvedTransactions(ctx, getTablet(shard.FindPrimaryTablet().GrpcPort), 1)
-		require.NoError(t, err)
-		if len(urtRes) > 0 {
-			unresTransaction = urtRes[0]
+	timeout := time.After(10 * time.Second)
+	for {
+		for _, shard := range clusterInstance.Keyspaces[0].Shards {
+			urtRes, err := tmc.GetUnresolvedTransactions(ctx, getTablet(shard.FindPrimaryTablet().GrpcPort), 1)
+			require.NoError(t, err)
+			if len(urtRes) > 0 {
+				unresTransaction = urtRes[0]
+			}
+		}
+		if unresTransaction != nil {
+			break
+		}
+		select {
+		case <-timeout:
+			require.Fail(t, "timed out waiting for unresolved transaction")
+		default:
 		}
 	}
 	require.NotNil(t, unresTransaction)