Skip to content

Commit

Permalink
Fix nil pointer error in test
Browse files Browse the repository at this point in the history
This test was never running since any panic would make a test pass
before removing the recovery handler.

Signed-off-by: Dirkjan Bussink <[email protected]>
  • Loading branch information
dbussink committed Dec 9, 2024
1 parent 3674b21 commit 475537d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/test/endtoend/recovery/pitr/shardedpitr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,6 @@ func launchRecoveryTablet(t *testing.T, tablet *cluster.Vttablet, binlogServer *
tablet.MysqlctlProcess = *mysqlctlProcess
extraArgs := []string{"--db-credentials-file", dbCredentialFile}
tablet.MysqlctlProcess.InitDBFile = initDBFileWithPassword
tablet.VttabletProcess.DbPassword = mysqlPassword
tablet.MysqlctlProcess.ExtraArgs = extraArgs
err = tablet.MysqlctlProcess.Start()
require.NoError(t, err)
Expand All @@ -544,6 +543,7 @@ func launchRecoveryTablet(t *testing.T, tablet *cluster.Vttablet, binlogServer *
clusterInstance.VtTabletExtraArgs,
clusterInstance.DefaultCharset)
tablet.Alias = tablet.VttabletProcess.TabletPath
tablet.VttabletProcess.DbPassword = mysqlPassword
tablet.VttabletProcess.SupportsBackup = true
tablet.VttabletProcess.Keyspace = restoreKeyspaceName
tablet.VttabletProcess.ExtraArgs = []string{
Expand Down

0 comments on commit 475537d

Please sign in to comment.