Mark non-unique lookup vindex as backfill to ignore vindex selection (#…

…14227)

Signed-off-by: Armand Parajon <[email protected]>

go/vt/vtgate/planbuilder/plan_test_vindex.go

@@ -72,7 +72,10 @@ func newLookupIndex(name string, _ map[string]string) (vindexes.Vindex, error) {
 var _ vindexes.Lookup = (*lookupIndex)(nil)
 
 // nameLkpIndex satisfies Lookup, NonUnique.
-type nameLkpIndex struct{ name string }
+type nameLkpIndex struct {
+	name       string
+	inBackfill bool
+}
 
 func (v *nameLkpIndex) String() string                     { return v.name }
 func (*nameLkpIndex) Cost() int                            { return 3 }
@@ -102,13 +105,21 @@ func (*nameLkpIndex) Query() (string, []string) {
 func (*nameLkpIndex) MapResult([]sqltypes.Value, []*sqltypes.Result) ([]key.Destination, error) {
 	return nil, nil
 }
-func newNameLkpIndex(name string, _ map[string]string) (vindexes.Vindex, error) {
-	return &nameLkpIndex{name: name}, nil
+
+func (v *nameLkpIndex) IsBackfilling() bool { return v.inBackfill }
+
+func newNameLkpIndex(name string, m map[string]string) (vindexes.Vindex, error) {
+	vdx := &nameLkpIndex{name: name}
+	if val, ok := m["write_only"]; ok {
+		vdx.inBackfill = val == "true"
+	}
+	return vdx, nil
 }
 
 var _ vindexes.Vindex = (*nameLkpIndex)(nil)
 var _ vindexes.Lookup = (*nameLkpIndex)(nil)
 var _ vindexes.LookupPlanable = (*nameLkpIndex)(nil)
+var _ vindexes.LookupBackfill = (*nameLkpIndex)(nil)
 
 // costlyIndex satisfies Lookup, NonUnique.
 type costlyIndex struct{ name string }

go/vt/vtgate/planbuilder/testdata/select_cases.json

@@ -4598,6 +4598,28 @@
       ]
     }
   },
+  {
+    "comment": "name is in backfill vindex - not selected for vindex lookup",
+    "query": "select * from customer where name = 'x'",
+    "plan": {
+      "QueryType": "SELECT",
+      "Original": "select * from customer where name = 'x'",
+      "Instructions": {
+        "OperatorType": "Route",
+        "Variant": "Scatter",
+        "Keyspace": {
+          "Name": "user",
+          "Sharded": true
+        },
+        "FieldQuery": "select * from customer where 1 != 1",
+        "Query": "select * from customer where `name` = 'x'",
+        "Table": "customer"
+      },
+      "TablesUsed": [
+        "user.customer"
+      ]
+    }
+  },
   {
     "comment": "email vindex is costly than phone vindex - but phone vindex is backfiling hence ignored",
     "query": "select * from customer where email = '[email protected]' and phone = 123456",

go/vt/vtgate/planbuilder/testdata/vschemas/schema.json

@@ -166,6 +166,16 @@
               "to": "keyspace_id",
               "cost": "300"
             }
+        },
+        "lkp_bf_vdx": {
+          "type": "name_lkp_test",
+          "owner": "customer",
+          "params": {
+            "table": "lkp_shard_vdx",
+            "from": " ",
+            "to": "keyspace_id",
+            "write_only": "true"
+          }
         }
       },
       "tables": {
@@ -476,6 +486,10 @@
             {
               "column": "phone",
               "name": "unq_lkp_bf_vdx"
+            },
+            {
+              "column": "name",
+              "name": "lkp_bf_vdx"
             }
           ]
         },

go/vt/vtgate/vindexes/consistent_lookup.go

@@ -489,7 +489,7 @@ func (lu *clCommon) GetCommitOrder() vtgatepb.CommitOrder {
 }
 
 // IsBackfilling implements the LookupBackfill interface
-func (lu *ConsistentLookupUnique) IsBackfilling() bool {
+func (lu *clCommon) IsBackfilling() bool {
 	return lu.writeOnly
 }
 

go/vt/vtgate/vindexes/lookup.go

@@ -181,6 +181,11 @@ func (ln *LookupNonUnique) MarshalJSON() ([]byte, error) {
 	return json.Marshal(ln.lkp)
 }
 
+// IsBackfilling implements the LookupBackfill interface
+func (ln *LookupNonUnique) IsBackfilling() bool {
+	return ln.writeOnly
+}
+
 // Query implements the LookupPlanable interface
 func (ln *LookupNonUnique) Query() (selQuery string, arguments []string) {
 	return ln.lkp.query()