Set FK checks off while creating schema in MoveTables atomic mode.

Signed-off-by: Rohit Nayak <[email protected]>

go/test/endtoend/vreplication/fk_config_test.go

@@ -23,12 +23,19 @@ create table child(id int, parent_id int, name varchar(128), primary key(id), fo
 create view vparent as select * from parent;
 create table t1(id int, name varchar(128), primary key(id)) engine=innodb;
 create table t2(id int, t1id int, name varchar(128), primary key(id), foreign key(t1id) references t1(id) on delete cascade) engine=innodb;
+create table t11 (id int primary key, i int);
+create table t12 (id int primary key, i int);
+alter table t11 add constraint f11 foreign key (i) references t12 (id);
+alter table t12 add constraint f12 foreign key (i) references t11 (id);
 `
 	initialFKData = `
 insert into parent values(1, 'parent1'), (2, 'parent2');
 insert into child values(1, 1, 'child11'), (2, 1, 'child21'), (3, 2, 'child32');
 insert into t1 values(1, 't11'), (2, 't12');
 insert into t2 values(1, 1, 't21'), (2, 1, 't22'), (3, 2, 't23');
+insert into t11 values(1, null);
+insert into t12 values(1, 1);
+update t11 set i = 1 where id = 1;
 `
 
 	initialFKSourceVSchema = `
@@ -37,7 +44,9 @@ insert into t2 values(1, 1, 't21'), (2, 1, 't22'), (3, 2, 't23');
 	"parent": {},
 	"child": {},
 	"t1": {},
-	"t2": {}
+	"t2": {},
+	"t11": {},
+	"t12": {}
   }
 }
 `
@@ -82,6 +91,22 @@ insert into t2 values(1, 1, 't21'), (2, 1, 't22'), (3, 2, 't23');
           "name": "reverse_bits"
         }
       ]
+    },
+    "t11": {
+      "column_vindexes": [
+        {
+          "column": "id",
+          "name": "reverse_bits"
+        }
+      ]
+    },
+    "t12": {
+      "column_vindexes": [
+        {
+          "column": "id",
+          "name": "reverse_bits"
+        }
+      ]
     }
   }
 }

go/test/endtoend/vreplication/fk_test.go

@@ -36,6 +36,8 @@ import (
 
 const testWorkflowFlavor = workflowFlavorRandom
 
+var counter int = 100
+
 // TestFKWorkflow runs a MoveTables workflow with atomic copy for a db with foreign key constraints.
 // It inserts initial data, then simulates load. We insert both child rows with foreign keys and those without,
 // i.e. with foreign_key_checks=0.
@@ -106,7 +108,9 @@ func TestFKWorkflow(t *testing.T) {
 	require.NotNil(t, targetTab)
 	catchup(t, targetTab, workflowName, "MoveTables")
 	vdiff(t, targetKeyspace, workflowName, cellName, true, false, nil)
-	ls.waitForAdditionalRows(200)
+	if withLoad {
+		ls.waitForAdditionalRows(200)
+	}
 	vdiff(t, targetKeyspace, workflowName, cellName, true, false, nil)
 	if withLoad {
 		cancel()
@@ -121,9 +125,7 @@ func TestFKWorkflow(t *testing.T) {
 		ls = newFKLoadSimulator(t, ctx)
 		defer cancel()
 		go ls.simulateLoad()
-	}
-	ls.waitForAdditionalRows(200)
-	if withLoad {
+		ls.waitForAdditionalRows(200)
 		cancel()
 		<-ch
 	}
@@ -137,9 +139,7 @@ func insertInitialFKData(t *testing.T) {
 		sourceKeyspace := "fksource"
 		shard := "0"
 		db := fmt.Sprintf("%s:%s", sourceKeyspace, shard)
-		log.Infof("Inserting initial FK data")
 		execMultipleQueries(t, vtgateConn, db, initialFKData)
-		log.Infof("Done inserting initial FK data")
 		waitForRowCount(t, vtgateConn, db, "parent", 2)
 		waitForRowCount(t, vtgateConn, db, "child", 3)
 		waitForRowCount(t, vtgateConn, db, "t1", 2)
@@ -193,8 +193,13 @@ func (ls *fkLoadSimulator) simulateLoad() {
 		default: // 20% chance to delete
 			ls.delete()
 		}
+		for _, table := range []string{"t11", "t12"} {
+			query := fmt.Sprintf("insert /*+ SET_VAR(foreign_key_checks=0) */ into fksource.%s values(%d, %d)", table, counter, counter)
+			ls.exec(query)
+			counter++
+		}
 		require.NoError(t, err)
-		time.Sleep(1 * time.Millisecond)
+		time.Sleep(10 * time.Millisecond)
 	}
 }
 

go/vt/mysqlctl/schema.go

@@ -536,6 +536,10 @@ func (mysqld *Mysqld) ApplySchemaChange(ctx context.Context, dbName string, chan
 		sql = "SET sql_log_bin = 0;\n" + sql
 	}
 
+	if change.SetForeignKeyChecksOff {
+		sql = "SET foreign_key_checks = 0;\n" + sql
+	}
+
 	// add a 'use XXX' in front of the SQL
 	sql = fmt.Sprintf("USE %s;\n%s", sqlescape.EscapeID(dbName), sql)
 

go/vt/mysqlctl/tmutils/schema.go

@@ -300,12 +300,13 @@ func DiffSchemaToArray(leftName string, left *tabletmanagerdatapb.SchemaDefiniti
 // SchemaChange contains all necessary information to apply a schema change.
 // It should not be sent over the wire, it's just a set of parameters.
 type SchemaChange struct {
-	SQL              string
-	Force            bool
-	AllowReplication bool
-	BeforeSchema     *tabletmanagerdatapb.SchemaDefinition
-	AfterSchema      *tabletmanagerdatapb.SchemaDefinition
-	SQLMode          string
+	SQL                    string
+	Force                  bool
+	AllowReplication       bool
+	BeforeSchema           *tabletmanagerdatapb.SchemaDefinition
+	AfterSchema            *tabletmanagerdatapb.SchemaDefinition
+	SQLMode                string
+	SetForeignKeyChecksOff bool
 }
 
 // Equal compares two SchemaChange objects.