Skip to content

Commit

Permalink
feat: fix docker image building
Browse files Browse the repository at this point in the history
Signed-off-by: Manan Gupta <[email protected]>
  • Loading branch information
GuptaManan100 committed May 27, 2024
1 parent e4d9a80 commit 7dbeffc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/vtop_example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ concurrency:
jobs:
build:
name: VTop Example
runs-on: ubuntu-latest
runs-on: gh-hosted-runners-16cores-1

steps:
- name: Skip CI
Expand Down
2 changes: 1 addition & 1 deletion docker/binaries/vtadmin/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ ARG DEBIAN_VER=bullseye-slim

FROM vitess/lite:${VT_BASE_VER} AS lite

FROM node:18-${DEBIAN_VER} as node
FROM node:20-${DEBIAN_VER} as node

# Prepare directory structure.
RUN mkdir -p /vt/web
Expand Down
2 changes: 1 addition & 1 deletion test/vtop_example.sh
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ EOF
# Build the docker image for vitess/lite using the local code
docker build -f docker/lite/Dockerfile -t vitess/lite:pr .
# Build the docker image for vitess/vtadmin using the local code
docker build -f docker/binaries/vtadmin/Dockerfile --build-arg VT_BASE_VER=pr -t vitess/vtadmin:pr .
docker build -f docker/binaries/vtadmin/Dockerfile --build-arg VT_BASE_VER=pr -t vitess/vtadmin:pr ./docker/binaries/vtadmin

# Print the docker images available
docker image ls
Expand Down

0 comments on commit 7dbeffc

Please sign in to comment.