fix typo and some refactor

Signed-off-by: Harshit Gangal <[email protected]>
vitessio · Feb 13, 2024 · a52c54a · a52c54a
1 parent 3d456e8
commit a52c54a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 40 deletions.
diff --git a/changelog/20.0/20.0.0/summary.md b/changelog/20.0/20.0.0/summary.md
@@ -13,7 +13,7 @@
 ## <a id="major-changes"/>Major Changes
 
 
-### <a id="query-compatibility"/>Query Serving
+### <a id="query-compatibility"/>Query Compatibility
 
 #### <a id="vindex-hints"/> Vindex Hints
 

diff --git a/go/vt/sqlparser/ast.go b/go/vt/sqlparser/ast.go
@@ -55,9 +55,6 @@ type (
 
 	OrderAndLimit interface {
 		AddOrder(*Order)
-		SetOrderBy(OrderBy)
-		GetOrderBy() OrderBy
-		GetLimit() *Limit
 		SetLimit(*Limit)
 	}
 
@@ -76,6 +73,9 @@ type (
 		GetColumns() SelectExprs
 		Commented
 		IsDistinct() bool
+		GetOrderBy() OrderBy
+		SetOrderBy(OrderBy)
+		GetLimit() *Limit
 	}
 
 	// DDLStatement represents any DDL Statement

diff --git a/go/vt/sqlparser/ast_funcs.go b/go/vt/sqlparser/ast_funcs.go
@@ -2606,34 +2606,10 @@ func MultiTable(node []TableExpr) bool {
 	return !singleTbl
 }
 
-func (node *Select) AddFrom(tbl TableExpr) {
-	node.From = append(node.From, tbl)
-}
-
-func (node *Update) AddFrom(tbl TableExpr) {
-	node.TableExprs = append(node.TableExprs, tbl)
-}
-
-func (node *Delete) AddFrom(tbl TableExpr) {
-	node.TableExprs = append(node.TableExprs, tbl)
-}
-
 func (node *Update) AddOrder(order *Order) {
 	node.OrderBy = append(node.OrderBy, order)
 }
 
-func (node *Update) SetOrderBy(by OrderBy) {
-	node.OrderBy = by
-}
-
-func (node *Update) GetOrderBy() OrderBy {
-	return node.OrderBy
-}
-
-func (node *Update) GetLimit() *Limit {
-	return node.Limit
-}
-
 func (node *Update) SetLimit(limit *Limit) {
 	node.Limit = limit
 }
@@ -2642,18 +2618,6 @@ func (node *Delete) AddOrder(order *Order) {
 	node.OrderBy = append(node.OrderBy, order)
 }
 
-func (node *Delete) SetOrderBy(by OrderBy) {
-	node.OrderBy = by
-}
-
-func (node *Delete) GetOrderBy() OrderBy {
-	return node.OrderBy
-}
-
-func (node *Delete) GetLimit() *Limit {
-	return node.Limit
-}
-
 func (node *Delete) SetLimit(limit *Limit) {
 	node.Limit = limit
 }