Minor changes after self review

Signed-off-by: Matt Lord <[email protected]>
vitessio · Feb 24, 2024 · d24a354 · d24a354
1 parent f1bbe35
commit d24a354
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/go/test/endtoend/tabletgateway/vtgate_test.go b/go/test/endtoend/tabletgateway/vtgate_test.go
@@ -81,7 +81,7 @@ func TestVtgateReplicationStatusCheck(t *testing.T) {
 			require.NoError(t, err)
 		}
 	}()
-	// Stop replication on the non-primary tablets.
+	// Stop replication on the non-PRIMARY tablets.
 	_, err = clusterInstance.VtctldClientProcess.ExecuteCommandWithOutput("ExecuteFetchAsDBA", clusterInstance.Keyspaces[0].Shards[0].Replica().Alias, "stop slave")
 	require.NoError(t, err)
 	_, err = clusterInstance.VtctldClientProcess.ExecuteCommandWithOutput("ExecuteFetchAsDBA", clusterInstance.Keyspaces[0].Shards[0].Rdonly().Alias, "stop slave")

diff --git a/go/vt/vtgate/executor.go b/go/vt/vtgate/executor.go
@@ -951,7 +951,7 @@ func (e *Executor) showVitessReplicationStatus(ctx context.Context, filter *sqlp
 				replLastError = row["Last_Error"].ToString()
 				if tabletenv.NewCurrentConfig().ReplicationTracker.Mode == tabletenv.Disable { // Use the value from mysqld
 					if row["Seconds_Behind_Master"].IsNull() {
-						replLag = "NULL" // Uppercase to match mysqld's output in SHOW REPLICA STATUS
+						replLag = strings.ToUpper(sqltypes.NullStr) // Uppercase to match mysqld's output in SHOW REPLICA STATUS
 					} else {
 						replLag = row["Seconds_Behind_Master"].ToString()
 					}