Skip to content

Commit

Permalink
18.0.3 release notes: ExecuteFetchAsDBA breaking change
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <[email protected]>
  • Loading branch information
shlomi-noach committed Jan 23, 2024
1 parent fdc8d1b commit e3159db
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions changelog/18.0/18.0.3/changelog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Changelog of Vitess v18.0.3
16 changes: 16 additions & 0 deletions changelog/18.0/18.0.3/release_notes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Release of Vitess v18.0.3
The entire changelog for this release can be found [here](https://github.com/vitessio/vitess/blob/main/changelog/18.0/18.0.3/changelog.md).

### <a id="breaking-changes"/>Breaking Changes

`vtctldclient ExecuteFetchAsDBA` (and similarly the `vtctl` and `vtctlclient` commands) now reject multi-statement SQL with error.

For example, `vtctldclient ExecuteFetchAsDBA my-tablet "stop replica; change replication source to auto_position=1; start replica` will return an error, without attempting to execute any of these queries.

Previously, `ExecuteFetchAsDBA` silently accepted multi statement SQL. It would (attempt to) execute all of them, but:

- It would only indicate error for the first statement. Errors on 2nd, 3rd, ... statements were silently ignored.
- It would not consume the result sets of the 2nd, 3rd, ... statements. It would then return the used connection to the pool in a dirty state. Any further query that happens to take that connection out of the pool could get unexpected results.
- As another side effect, multi-statement schema changes would cause schema to be reloaded with only the 1st change, leaving the cached schema inconsistent with the underlying database.

`ExecuteFetchAsDBA` does allow a specific use case of multi-statement SQL, which is where all statements are in the form of `CREATE TABLE` or `CREATE VIEW`. This is to support a common pattern of schema initialization, formalized in `ApplySchema --batch-size` which uses `ExecuteFetchAsDBA` under the hood.
4 changes: 4 additions & 0 deletions changelog/18.0/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
## v18.0
* **[18.0.3](18.0.3)**
* [Changelog](18.0.3/changelog.md)
* [Release Notes](18.0.3/release_notes.md)

* **[18.0.2](18.0.2)**
* [Changelog](18.0.2/changelog.md)
* [Release Notes](18.0.2/release_notes.md)
Expand Down

0 comments on commit e3159db

Please sign in to comment.