Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Wait for DBA grants can cause restore to get stuck if there's an unexpected crash #14681

Closed
dbussink opened this issue Dec 5, 2023 · 0 comments · Fixed by #14680

Comments

@dbussink
Copy link
Contributor

dbussink commented Dec 5, 2023

Overview of the Issue

Since #14565, if you have a backup restore and for some reason vttablet crashes mid-restore, things get stuck. vttablet can crash due to things like an OOM error, a crashing server or anything else.

When this happens mysqld will still be shut down as the restore phase shuts it down. The new vttablet started after the crash will fail to start up, because it can't connect to MySQL to verify the DBA grants.

Before the change in #14565 this was not a problem, since the restore step doesn't actually depend on connecting to MySQL at all, so it would be able to retry. It would only warn MySQL was already shut down, but otherwise continue.

Reproduction Steps

Binary Version

since #14565

Operating System and Environment details

-

Log Fragments

-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants