-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtorc: add detected_problems counter #13967
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37ed0c9
vtorc/inst: add AnalysisCodes()
yields b7cf014
vtorc/logic: add detected_problems counter
yields f1b0c4a
vtorc/logic: add tablet_alias, keyspace and shard to counter
yields ea7ea68
vtorc/logic: AnalysisCode -> Analysis
yields cf866ba
vtorc/inst: remove unused AnalaysisCodes()
yields 82b4a75
vtorc/logic: fix err scoping
yields bba7fd1
stats: add GetLabelName()
yields fda66ef
vtorc/logic: set counter to 1 when issue detected, reset when its no …
yields 7371434
stats: move GetLabelName to GaugesWithMultiLabels
yields 155a803
vtorc/logic: use gauge for detected problems
yields 527d322
stats: add (*GaugesWithMultiLabels).ResetKey
yields 696ea3e
vtorc/logic: use .ResetKey to reset a gauge
yields c13d6b3
test/endtoend: add detected problems endtoend test
yields d604b01
Merge remote-tracking branch 'upstream/main' into a/vtorc-stat
GuptaManan100 7e07f06
test: use the newly introduced getIntFromValue function
GuptaManan100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looked like a bug to me so changed the scoping here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes! Good catch.