-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-16.0] moved timeout test to different package (#14028) #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitess-bot
bot
added
Backport
This is a backport
Component: Query Serving
Merge Conflict
Skip CI
Skip CI actions from running
Type: Internal Cleanup
labels
Sep 19, 2023
Hello @harshit-gangal, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace
|
vitess-bot
bot
requested review from
deepthi,
GuptaManan100,
harshit-gangal,
mattlord,
rohit-nayak-ps and
systay
September 19, 2023 15:15
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Sep 19, 2023
harshit-gangal
force-pushed
the
backport-14028-to-release-16.0
branch
from
September 19, 2023 17:33
4960776
to
f5e2fc5
Compare
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
Skip CI
Skip CI actions from running
NeedsIssue
A linked issue is missing for this Pull Request
Merge Conflict
labels
Sep 19, 2023
harshit-gangal
force-pushed
the
backport-14028-to-release-16.0
branch
from
September 19, 2023 17:41
f5e2fc5
to
022cde4
Compare
frouioui
approved these changes
Sep 19, 2023
harshit-gangal
approved these changes
Sep 20, 2023
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
backport-14028-to-release-16.0
branch
from
September 20, 2023 02:16
022cde4
to
340300a
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #14028