Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-17.0] backport mysqlctl CLI compatibility fix to 17.0 #14082

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Sep 22, 2023

Description

This backports 514c946 to 17.0, which is needed so upgrade/downgrade tests (upgrading to 18.0 on 17.0) work properly.

Related Issue(s)

#13946

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 requested a review from frouioui September 22, 2023 17:26
@ajm188 ajm188 requested a review from deepthi as a code owner September 22, 2023 17:26
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 22, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 22, 2023
@ajm188 ajm188 added Type: Bug Backport This is a backport Component: CLI Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 22, 2023
@github-actions github-actions bot added this to the v17.0.3 milestone Sep 22, 2023
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 merged commit 173e6af into vitessio:release-17.0 Sep 22, 2023
111 of 112 checks passed
@ajm188 ajm188 deleted the bp-mysqlctl-compat branch September 22, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants