Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use panic instead of errors inside the operator package #14085

Merged
merged 15 commits into from
Oct 10, 2023
Merged

Use panic instead of errors inside the operator package #14085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a120ee4
make AddColumn panic instead of returning an error
systay Oct 9, 2023
809ac6e
refactor: make AddPredicate panic instead of return error
systay Oct 9, 2023
6ba7dd0
refactor: use panic instead of errors for SQL_builder
systay Oct 9, 2023
ed2a589
refactor: panic instead of error for FindCol
systay Oct 9, 2023
eca1841
refactor: panic instead of error for GetOrdering
systay Oct 9, 2023
42074b3
refactor: panic instead of error for GetColumns
systay Oct 9, 2023
d8fc33c
refactor: panic instead of error for GetSelectExprs
systay Oct 9, 2023
435cf2e
refactor: panic instead of error for planOffsets
systay Oct 9, 2023
d3d8ba9
refactor: panic instead of error for RewriteExpression
systay Oct 10, 2023
5a98e3a
refactor: panic instead of error for addColumnWithoutPushing
systay Oct 10, 2023
8a9260d
refactor: panic instead of error for addColumnsWithoutPushing
systay Oct 10, 2023
ed46feb
refactor: panic instead of error for findColInternal
systay Oct 10, 2023
8f35800
refactor: panic instead of error for aggregator.go
systay Oct 10, 2023
5476331
refactor: panic instead of error for horizon_expanding
systay Oct 10, 2023
ac9d992
refactor: panic instead of error for merging logic
systay Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions go/vt/vtgate/planbuilder/operator_transformers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,7 @@ func getEvalEngingeExpr(ctx *plancontext.PlanningContext, pe *operators.ProjExpr
// useSimpleProjection uses nothing at all if the output is already correct,
// or SimpleProjection when we have to reorder or truncate the columns
func useSimpleProjection(ctx *plancontext.PlanningContext, op *operators.Projection, cols []int, src logicalPlan) (logicalPlan, error) {
columns, err := op.Source.GetColumns(ctx)
if err != nil {
return nil, err
}
columns := op.Source.GetColumns(ctx)
if len(columns) == len(cols) && elementsMatchIndices(cols) {
// the columns are already in the right order. we don't need anything at all here
return src, nil
Expand Down
Loading
Loading