Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitess MySQL Docker Image #14158

Merged
merged 15 commits into from
Oct 3, 2023
Merged

Vitess MySQL Docker Image #14158

merged 15 commits into from
Oct 3, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Oct 2, 2023

Description

This Pull Request adds a new Docker Image: vitess/mysql (visible on DockerHub here). The image is built of the main branch of the repository. Each tag of that image represent a certain MySQL version, for now in this PR only 8.0.30 (current MySQL version of Vitess) and 8.0.34 (latest 8.0 MySQL version) are available and will be built.

This PR is the first building-block to support major MySQL upgrades in the vitess-operator. Since the mysqld container image will be tagged by the underlying MySQL version, detecting a MySQL upgrade when the end-users apply a new image/tag will be possible.

In the future, the vitess/mysql image will be used by new Vitess deployments on K8S instead of using vitess/lite for the mysqld container. For now, this PR just focuses on creating the images and making them available for the incoming vitess-operator work.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Signed-off-by: Florent Poinsard <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 2, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 2, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 2, 2023
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 2, 2023
@frouioui frouioui marked this pull request as ready for review October 2, 2023 23:01
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@frouioui frouioui merged commit 79bb6e3 into vitessio:main Oct 3, 2023
115 checks passed
@frouioui frouioui deleted the own-mysql-image branch October 3, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants