Fix data race in TestWarmingReads
#14187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the data race as pointed out in #14186.
The data race was happening on the replica tablet. In the test
TestWarmingReads
, warming read queries are run on the replica asynchronously. This lead to theQueries
field in the sandboxconn being updated in a separate go-routine than the main go routine. This causes the read and writes to this variable in the main go routine to error with a data race.This has been fixed in this PR by adding synchronization to that variable. This however has been added only when it is required so as to not hamper performance of the other tests.
The test
TestWarmingReads
was introduced in #13206Related Issue(s)
TestWarmingReads
#14186Checklist
Deployment Notes