Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-16.0] Upgrade the Golang version to go1.20.10 #14228

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[release-16.0] Upgrade the Golang version to go1.20.10 #14228

merged 2 commits into from
Oct 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2023 •
edited by frouioui
Loading

This Pull Request bumps the Golang version to go1.20.10 and the bootstrap version to 14.9.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests. Bump upgrade workflows to go1.20.10 #14232
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.10

@github-actions github-actions bot added the Benchmark me Add label to PR to run benchmarks label Oct 10, 2023
@github-actions github-actions bot added Component: General Changes throughout the code base go labels Oct 10, 2023
@github-actions github-actions bot requested a review from frouioui as a code owner October 10, 2023 23:10
@github-actions github-actions bot added Skip CI Skip CI actions from running Type: CI/Build labels Oct 10, 2023
@frouioui frouioui mentioned this pull request Oct 10, 2023
Merged
@frouioui frouioui force-pushed the upgrade-go-to-1.20.10-on-release-16.0 branch from 4f0efde to d57dc13 Compare October 10, 2023 23:52
@frouioui frouioui removed the Skip CI Skip CI actions from running label Oct 10, 2023
@frouioui
Bump all workflows to 1.20.10
7d1a5b1 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.10-on-release-16.0 branch from d57dc13 to 7d1a5b1 Compare October 11, 2023 00:53
@frouioui frouioui removed the Benchmark me Add label to PR to run benchmarks label Oct 11, 2023
@frouioui frouioui merged commit 239b7b4 into release-16.0 Oct 11, 2023
222 checks passed
@frouioui frouioui deleted the upgrade-go-to-1.20.10-on-release-16.0 branch October 11, 2023 17:42
@frouioui frouioui added this to the v16.0.6 milestone Oct 31, 2023
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi deepthi approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Milestone
v16.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@deepthi @ajm188 @frouioui